Fix missing pip issue on travis #292

dorukozturk · 2017-11-30T18:48:42Z

No description provided.

nicain

Looks good!

dorukozturk · 2017-11-30T18:55:24Z

@nicain This will take a while (1 hour or so). Once travis passes I will merge it and you can rebase.

nicain · 2017-11-30T22:43:21Z

@dorukozturk These last two checks, travis and appveyor, seem to take forever. appveyor never even ran on my last PR. Any thoughts about what the slow-down could be? Maybe our project got throttled?

nicain · 2017-12-01T18:16:55Z

@dorukozturk ping. This delay in running ci seems really strange. Any ideas what could be going on?

dorukozturk · 2017-12-01T18:24:42Z

@nicain Travis was always slow. I think they cannot run macOS virtually so there is a big queue. Appveyor is weird though. I think I will just contact them and see what is going on. If @jcfr thinks it is ok we can maybe merge this PR since circle tests pass. I don't want to block you anymore.

nicain · 2017-12-01T18:30:02Z

OK. TBH I am blocked by the fix you provide here, and the slow CI from travis and appveyor, so even if you do merge this Ill still need to wait until we can resolve the travis/appveyor slowness. I need the change in #288 to keep working on #275, so I can just keep driving at that. So my opinion is don't merge, lets get to the root of the problem.

dorukozturk · 2017-12-01T19:13:51Z

@nicain Sorry I thought I was commenting on your PR as opposed to mine (I mean maybe we should merge your PR) . I contacted the Appveyor people and they fixed the Windows build issue. Travis is still up in the air and I am trying to fix it.

nicain · 2017-12-01T19:15:11Z

Awesome. Just saw this: https://circleci.com/blog/one-more-thing-apple-developers-can-now-build-for-macos-ios-tvos-and-watchos-on-circleci-2-0/ We are using travis for macOS, right? Can we move that over to circleci?

dorukozturk · 2017-12-01T19:29:51Z

@nicain We just talked about this with Jc. I think it is a paid option but it should be a big gain time-wise on our builds.

jcfr · 2017-12-01T19:39:25Z

circleci 2.0 macos

I tried to set CircleCI 2 for macos (in addition of the docker) up for a project with the same problem. See scikit-build/scikit-ci-addons@7f0c8d5

But it is shown as "Not running", this happen because it is not free.

Here are the pricing details: https://circleci.com/pricing/#build-os-x

Cc: @mgrauer

That said, I will have an other look at the pip issue on travis for macos. This happen because of the recent update of macOS image by Travis and the fact we try to install the support tooling on system python.

jcfr · 2017-12-01T19:48:41Z

.travis.yml

@@ -38,6 +38,8 @@ cache:
    - $HOME/.pyenv/versions/2.7.14

 before_install:
+  - wget https://bootstrap.pypa.io/get-pip.py
+  - python get-pip.py


The following will work:

curl --silent --show-error https://bootstrap.pypa.io/get-pip.py | sudo -H python

codecov-io · 2017-12-01T19:52:08Z

Codecov Report

Merging #292 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #292      +/-   ##
==========================================
+ Coverage   42.82%   42.84%   +0.02%     
==========================================
  Files          35       35              
  Lines        3622     3622              
  Branches      719      719              
==========================================
+ Hits         1551     1552       +1     
  Misses       1931     1931              
+ Partials      140      139       -1

Flag	Coverage Δ
#form	`42.84% <ø> (+0.02%)`	⬆️
#integration	`42.84% <ø> (+0.02%)`	⬆️
#pynwb	`42.84% <ø> (+0.02%)`	⬆️

Impacted Files	Coverage Δ
src/pynwb/form/utils.py	`73.61% <0%> (+0.34%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765d9e3...951f660. Read the comment docs.

nicain

Thanks all, glad this seems to be working.

jcfr · 2017-12-04T18:44:09Z

.circleci/config.yml

@@ -14,7 +14,7 @@ initialize-venv: &initialize-venv
 publish-prerelease-on-github: &publish-prerelease-on-github
  name: Publish wheel and source distribution on github
  command: |
-    if [ "${CIRCLE_BRANCH}" == "dev" ]; then
+    if [[ "${CIRCLE_BRANCH}" == "dev" && "${PUBLISH_RELEASE}" == "true" ]]; then


This should always be done.

The variable should probably be named UPLOAD_WHEELS or PUBLISH_WHEELS ... having the word RELEASE in the name of the variable seems that the actual "stable release" is published ...

Yup I agree; this tricked me until you made this comment.

Ok, I rebased it (changes in the cirlcle config are gone for this PR) and will merge this since this PR fixed the travis issue.

Full disclosure, I made the commit adding this variable. I will do a follow up Pr as soon as CI fixes are all integrated

dorukozturk changed the title ~~Fix missing pip issue on travis~~ [WIP] Fix missing pip issue on travis Nov 30, 2017

nicain previously approved these changes Nov 30, 2017

View reviewed changes

dorukozturk dismissed nicain’s stale review via 4c2017c November 30, 2017 19:44

dorukozturk force-pushed the fix-travis-pip-error branch from 8f2f6a1 to 4c2017c Compare November 30, 2017 19:44

dorukozturk force-pushed the fix-travis-pip-error branch 6 times, most recently from 5577be2 to 7a8e39b Compare December 1, 2017 17:23

jcfr reviewed Dec 1, 2017

View reviewed changes

dorukozturk force-pushed the fix-travis-pip-error branch from 7a8e39b to c9c25ee Compare December 1, 2017 19:51

dorukozturk force-pushed the fix-travis-pip-error branch from c9c25ee to 42136b3 Compare December 1, 2017 21:03

nicain previously approved these changes Dec 2, 2017

View reviewed changes

dorukozturk changed the title ~~[WIP] Fix missing pip issue on travis~~ Fix missing pip issue on travis Dec 2, 2017

dorukozturk dismissed nicain’s stale review via e503aa5 December 2, 2017 19:20

dorukozturk force-pushed the fix-travis-pip-error branch 4 times, most recently from 19cbb53 to d7fcf5e Compare December 2, 2017 19:40

dorukozturk force-pushed the fix-travis-pip-error branch 18 times, most recently from ad27857 to 951f660 Compare December 4, 2017 18:07

jcfr reviewed Dec 4, 2017

View reviewed changes

Fix missing pip issue on travis

1c71be6

dorukozturk force-pushed the fix-travis-pip-error branch from 951f660 to 1c71be6 Compare December 4, 2017 19:32

jcfr mentioned this pull request Dec 4, 2017

circle config: Rename PUBLISH_RELEASE variable #294

Closed

dorukozturk merged commit 216cbb3 into dev Dec 4, 2017

dorukozturk deleted the fix-travis-pip-error branch December 4, 2017 20:04

nicain mentioned this pull request Dec 4, 2017

Refactor get_builder_dt legacy to be explicit #288

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing pip issue on travis #292

Fix missing pip issue on travis #292

dorukozturk commented Nov 30, 2017

nicain left a comment

dorukozturk commented Nov 30, 2017

nicain commented Nov 30, 2017

nicain commented Dec 1, 2017

dorukozturk commented Dec 1, 2017

nicain commented Dec 1, 2017 •

edited

Loading

dorukozturk commented Dec 1, 2017

nicain commented Dec 1, 2017

dorukozturk commented Dec 1, 2017

jcfr commented Dec 1, 2017

jcfr Dec 1, 2017

codecov-io commented Dec 1, 2017 •

edited

Loading

nicain left a comment

jcfr Dec 4, 2017

jcfr Dec 4, 2017

nicain Dec 4, 2017

dorukozturk Dec 4, 2017

jcfr Dec 4, 2017

Fix missing pip issue on travis #292

Fix missing pip issue on travis #292

Conversation

dorukozturk commented Nov 30, 2017

nicain left a comment

Choose a reason for hiding this comment

dorukozturk commented Nov 30, 2017

nicain commented Nov 30, 2017

nicain commented Dec 1, 2017

dorukozturk commented Dec 1, 2017

nicain commented Dec 1, 2017 • edited Loading

dorukozturk commented Dec 1, 2017

nicain commented Dec 1, 2017

dorukozturk commented Dec 1, 2017

jcfr commented Dec 1, 2017

jcfr Dec 1, 2017

Choose a reason for hiding this comment

codecov-io commented Dec 1, 2017 • edited Loading

Codecov Report

nicain left a comment

Choose a reason for hiding this comment

jcfr Dec 4, 2017

Choose a reason for hiding this comment

jcfr Dec 4, 2017

Choose a reason for hiding this comment

nicain Dec 4, 2017

Choose a reason for hiding this comment

dorukozturk Dec 4, 2017

Choose a reason for hiding this comment

jcfr Dec 4, 2017

Choose a reason for hiding this comment

nicain commented Dec 1, 2017 •

edited

Loading

codecov-io commented Dec 1, 2017 •

edited

Loading