-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated methods from NWBFile #2033
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2033 +/- ##
==========================================
+ Coverage 91.73% 91.83% +0.10%
==========================================
Files 27 27
Lines 2722 2683 -39
Branches 710 702 -8
==========================================
- Hits 2497 2464 -33
+ Misses 149 144 -5
+ Partials 76 75 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@stephprince @rly not sure if this should be for 3.0 or 4.0 release |
I think these changes are all covered by #2011, which was merged into the release-3.0.0 branch but has not yet been merged into dev. |
@oruebel can I close this PR since I think these changes are covered in the release-3.0.0 branch as mentioned above? If there are additional changes here that should be merged, let me know. |
Motivation
This PR removes previously deprecated functions and parameter from
NWBFile
Checklist
ruff check . && codespell
from the source directory.