Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Images object not present in the pynwb.image API #2022

Open
3 tasks done
h-mayorquin opened this issue Jan 27, 2025 · 3 comments · May be fixed by #2029
Open
3 tasks done

[Documentation]: Images object not present in the pynwb.image API #2022

h-mayorquin opened this issue Jan 27, 2025 · 3 comments · May be fixed by #2029
Labels
category: question questions about code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation

Comments

@h-mayorquin
Copy link
Contributor

What would you like changed or added to the documentation and why?

This works on my system:

from pynwb.image import Images

But the object is not found in the images API:

https://pynwb.readthedocs.io/en/stable/pynwb.image.html

Instead, it is found on base:

https://pynwb.readthedocs.io/en/stable/pynwb.base.html#pynwb.base.Images

It makes sense to me that it should be on Images as I would look for that but maybe it should be duplicated to be here and in base?

Should pynwb.base be internal?

I guess slightly related to #1686

Do you have any interest in helping write or edit the documentation?

No.

Code of Conduct

@h-mayorquin h-mayorquin changed the title [Documentation]: Images object not present in the pynwb.image API even if we can be imported [Documentation]: Images object not present in the pynwb.image API ` Jan 27, 2025
@h-mayorquin h-mayorquin changed the title [Documentation]: Images object not present in the pynwb.image API ` [Documentation]: Images object not present in the pynwb.image API Jan 27, 2025
@stephprince
Copy link
Contributor

stephprince commented Jan 29, 2025

It looks like Images was added to pynwb.base originally (#693) and reflects the structure of the schema: nwb.base.yaml.

@rly or @bendichter can you comment on @h-mayorquin's questions?

@stephprince stephprince added priority: low alternative solution already working and/or relevant to only specific user(s) category: question questions about code or code behavior topic: docs issues related to documentation labels Jan 29, 2025
@bendichter
Copy link
Contributor

@h-mayorquin how about this?

Image

@h-mayorquin
Copy link
Contributor Author

I think the list/summary at the top of pynwb.Image looks great. It addresses the case of someone looking for Images in pynwb.image and not finding it there.

@bendichter bendichter linked a pull request Jan 29, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: question questions about code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants