Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default options for chunking of datasets (issue #635) #636

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Merge branch 'master' into 635-customizable-chunking

837d808
Select commit
Loading
Failed to load commit list.
Draft

Provide default options for chunking of datasets (issue #635) #636

Merge branch 'master' into 635-customizable-chunking
837d808
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

94.69% (target 90.00%)

View this Pull Request on Codecov

94.69% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 79.62963% with 33 lines in your changes missing coverage. Please review.

Project coverage is 94.69%. Comparing base (ab53589) to head (837d808).

Files with missing lines Patch % Lines
...config/+internal/resolveDatasetConfigForDataType.m 56.00% 11 Missing ⚠️
+io/+config/+internal/configureDataPipeFromData.m 60.86% 9 Missing ⚠️
+io/+config/readDatasetConfiguration.m 71.42% 4 Missing ⚠️
+schemes/listDatasetsOfNeurodataType.m 81.81% 4 Missing ⚠️
+io/+config/+internal/computeChunkSizeFromConfig.m 90.32% 3 Missing ⚠️
+io/+config/applyDatasetConfiguration.m 95.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   95.18%   94.69%   -0.49%     
==========================================
  Files         124      132       +8     
  Lines        5045     5207     +162     
==========================================
+ Hits         4802     4931     +129     
- Misses        243      276      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov