Support overwrite of string array attributes #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow us to dynamically add columns to a DynamicTable (even one that was read from a file), we need to be able to update the
colNames
attribute.BaseIO.createAttribute
for string arrays to explicitly allow us to force overwrite of existing attributes and updatedHDF5IO.createAttribute
accordingly. HDF5 does not support expanding attributes in the same way it does for datasets so we need to delete the existing attribute and overwrite it with a new one with the same name.HDF5IO
accordingly and enhanced tests forHDF5IO.createAttribute
DynamicTable.finalize
to overwrite column names to correctly support appending of columns to existing tablesDynamicTable
constructor to read the existing column names if they exist from the file so that we can append new columns to existing tablesDynamicTable.add_column
to avoid unnecessary iteration and usewriteDataBlock
directlyElectrodeTable
to use variable length strings instead of fixed length stringsContainer.initialize
to correctly return its StatusDynamicTable