Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of the session start time and timestamp reference time #144

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 19, 2025

Fix #8

This PR is not critical, just taking care of a minor issue that was assigned to me

@oruebel oruebel requested a review from stephprince January 19, 2025 09:01
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (c5ac566) to head (c7767f4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   92.96%   93.20%   +0.24%     
==========================================
  Files          62       62              
  Lines        4278     4328      +50     
  Branches      266      268       +2     
==========================================
+ Hits         3977     4034      +57     
+ Misses        291      284       -7     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Added a couple of comments.

src/nwb/NWBFile.hpp Outdated Show resolved Hide resolved
src/nwb/NWBFile.cpp Outdated Show resolved Hide resolved
src/nwb/NWBFile.hpp Outdated Show resolved Hide resolved
@oruebel
Copy link
Contributor Author

oruebel commented Jan 27, 2025

@stephprince I implemented the code changes you had suggested.

@oruebel oruebel merged commit 00a529c into main Jan 27, 2025
10 checks passed
@oruebel oruebel deleted the set_session_time branch January 27, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for acquisition system to supply session start and reference times
3 participants