-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading of arbitrary fields #142
Conversation
Add unit tests for BaseIO::findTypes
@stephprince sorry in case this caused confusion, but I needed the changes from #139 here for testing, and since #139 was not merged yet I combined it with this PR so I could run the tests. This PR is now ready for review. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 92.01% 92.96% +0.94%
==========================================
Files 61 62 +1
Lines 4009 4278 +269
Branches 262 266 +4
==========================================
+ Hits 3689 3977 +288
+ Misses 310 291 -19
Partials 10 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Added some minor suggestions.
Co-authored-by: Steph Prince <[email protected]>
Co-authored-by: Steph Prince <[email protected]>
@stephprince can you please re-approve. I committed your suggestions and added the test case you had suggested in 19fecb4 |
This PR is to prepare for #130
getGroupObjects
method togetStorageObjects
to allow for more general lookup of groups, datasets, and attributes. The current method is limited to look-up of groups within a group. The updatedgetStorageObjects
now supports: 1) lookup starting from datasets and groups and 2) retrieval of groups, datasets, and attributes, 3) allows the user to specify what types of storage objects to retrieve.findTypes
function, which previously only looked atGroups
so typed objects that were datasets (e.g.,VectorData
) would have been ignored.findTypes
and missing tests forRegisteredType
andHDF5IO
RegisteredType::readField
function for reading arbitrary dataset and attribute fieldsRegisteredType::readField
method to allow reading of arbitrary fields that are itself instances ofRegisteredType
, such as, readingVectorData
from aDynamicTable
or readingElectricalSeries
from anNWBFile
Fix #133
Fix #131