Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Utils.hpp #137

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add unit tests for Utils.hpp #137

merged 1 commit into from
Jan 15, 2025

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 14, 2025

No description provided.

@oruebel
Copy link
Contributor Author

oruebel commented Jan 14, 2025

@stephprince note, I did not add unit tests for the convertFloatToInt16LE function because the behavior in edge cases was not clear to me and led to errors when I tried to create tests for it automatically with Cline.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.83%. Comparing base (354147f) to head (e245449).

Files with missing lines Patch % Lines
src/Utils.hpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   91.66%   91.83%   +0.16%     
==========================================
  Files          57       58       +1     
  Lines        3839     3894      +55     
  Branches      254      256       +2     
==========================================
+ Hits         3519     3576      +57     
+ Misses        310      308       -2     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel requested a review from stephprince January 14, 2025 23:11
@oruebel oruebel merged commit e7f4b7e into main Jan 15, 2025
10 checks passed
@oruebel oruebel deleted the add_utils_tests branch January 15, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants