Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov badge to README.md #135

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Add codecov badge to README.md #135

merged 10 commits into from
Jan 21, 2025

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 13, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (c2ee9e6) to head (0b2133a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files          58       58           
  Lines        3893     3893           
  Branches      256      256           
=======================================
  Hits         3575     3575           
  Misses        308      308           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oruebel oruebel requested a review from stephprince January 14, 2025 22:01
stephprince
stephprince previously approved these changes Jan 15, 2025
Copy link
Collaborator

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! However the overall code coverage percentage is still including the test suite currently. I'm not sure if we want to fix that first before including in the README to be more accurate

@oruebel
Copy link
Contributor Author

oruebel commented Jan 15, 2025

Looks good to me! However the overall code coverage percentage is still including the test suite currently. I'm not sure if we want to fix that first before including in the README to be more accurate

Sounds good. Please just merge when this is ready .

@stephprince
Copy link
Collaborator

Tested out some changes to the coverage command here, but was still running into issues on what folders were included in the report uploaded to CodeCov. Will address these in a separate issue.

@stephprince stephprince merged commit 6b1dbc6 into main Jan 21, 2025
8 checks passed
@stephprince stephprince deleted the add_codecove_badge branch January 21, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants