Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update read example #123

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Update read example #123

merged 13 commits into from
Jan 13, 2025

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 8, 2025

#118 fixed several issues with read so this PR updates the read example to resolve a few items that were marked as TODO in the example that are now working.

@oruebel oruebel requested a review from stephprince January 8, 2025 23:37
@oruebel oruebel mentioned this pull request Jan 8, 2025
49 tasks
@oruebel oruebel mentioned this pull request Jan 12, 2025
5 tasks
@oruebel oruebel changed the base branch from add_read to add_read_explicit_open January 13, 2025 00:51
@oruebel
Copy link
Contributor Author

oruebel commented Jan 13, 2025

Changed the base branch to #128 temporarily to see if the changes there fix the issues here. We can change back to target #85 again later.

Base automatically changed from add_read_explicit_open to add_read January 13, 2025 18:20
@oruebel
Copy link
Contributor Author

oruebel commented Jan 13, 2025

Ok, I finally figured out the Windows issue. The problem was that the espath used for reading was determined in this loop:

// Print the path and type of the found objects
for (const auto& pair : found_electrical_series) {
std::cout << "Path=" << pair.first << " Full type=" << pair.second
<< std::endl;
esdata_path = pair.first;
}

On Windows the order of paths is different and so the wrong ElectricalSeries was used, and since the size of the two series was different this led to an out-of-bounds error.

@oruebel
Copy link
Contributor Author

oruebel commented Jan 13, 2025

@stephprince this PR is now also ready for review

@oruebel oruebel merged commit 9d5d173 into add_read Jan 13, 2025
9 checks passed
@oruebel oruebel deleted the add_read_examples branch January 13, 2025 19:20
@oruebel
Copy link
Contributor Author

oruebel commented Jan 13, 2025

@stephprince I merged with #85 just so that I can finalize things there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant