-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read example #123
Update read example #123
Conversation
Ok, I finally figured out the Windows issue. The problem was that the aqnwb/tests/examples/test_ecephys_data_read.cpp Lines 203 to 208 in 14a825c
On Windows the order of paths is different and so the wrong ElectricalSeries was used, and since the size of the two series was different this led to an out-of-bounds error. |
@stephprince this PR is now also ready for review |
@stephprince I merged with #85 just so that I can finalize things there |
#118 fixed several issues with read so this PR updates the read example to resolve a few items that were marked as TODO in the example that are now working.