Mix portsadm node role with existing roles #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As only one role can be granted to a module on the local node, define additional roles, given by the union of existing roles fwadm and tunadm.
The deallocate-ports action step is unnecessary since the allocate-ports/deallocate-ports node actions do not manage "_rsync" allocations. These can only be handled by the cluster agent.
tommaso-ascani
approved these changes
Oct 8, 2024
gsanchietti
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As only one role can be granted to a module on the local node, define additional roles, given by the union of existing roles fwadm and tunadm.
Remove import-module/99deallocate_ports step, because a module is not authorized to remove _rsync allocations despite its role on the local node.
Refs NethServer/dev#6974