Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipv6 localhost to local_access_spec #181

Closed
wants to merge 1 commit into from
Closed

Conversation

Stell0
Copy link
Contributor

@Stell0 Stell0 commented May 2, 2024

return also ipv6 localhost address

When list of local access is requested, also ipv6 should be returned

for instance, Tancredi accepts request from localhost, but ::1 isn't in adress list and if ::1 is in /etc/hosts, requests are rejected

return also ipv6 localhost address
@Stell0 Stell0 requested a review from DavidePrincipi May 2, 2024 08:03
@nethbot
Copy link
Member

nethbot commented May 2, 2024

in 7.9.2009/autobuild:

@Stell0 Stell0 marked this pull request as ready for review May 6, 2024 08:38
Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the PR should work as expected, this change may impact too many services: not all services correctly support the IPv6 notation.
Let's move the fix inside the tancredi package.

@Stell0 Stell0 closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants