Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): enhanced connection process #372

Merged
merged 3 commits into from
Oct 3, 2024
Merged

fix(controller): enhanced connection process #372

merged 3 commits into from
Oct 3, 2024

Conversation

Tbaile
Copy link
Collaborator

@Tbaile Tbaile commented Sep 30, 2024

Modal:

Screencast.from.2024-09-30.17-23-28.mp4

Ref:

@Tbaile Tbaile changed the title fix(controller): unit now shows a modal of confirmation when connecting fix(controller): enhanced connection process Oct 1, 2024
@Tbaile Tbaile marked this pull request as ready for review October 1, 2024 08:00
@Tbaile Tbaile requested a review from andre8244 October 1, 2024 08:00
public/i18n/en/translation.json Outdated Show resolved Hide resolved
public/i18n/en/translation.json Outdated Show resolved Hide resolved
public/i18n/en/translation.json Outdated Show resolved Hide resolved
public/i18n/en/translation.json Outdated Show resolved Hide resolved
@Tbaile Tbaile requested a review from andre8244 October 2, 2024 13:44
Copy link
Collaborator

@andre8244 andre8244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an optional 18n enhancement

public/i18n/en/translation.json Outdated Show resolved Hide resolved
@Tbaile Tbaile merged commit de5cb97 into main Oct 3, 2024
3 checks passed
@Tbaile Tbaile deleted the controller-754 branch October 3, 2024 13:29
@Tbaile Tbaile mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants