Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nethvoice, Nethvoice-proxy: Don't use NS8's default environment for sensitive data #7011

Closed
8 tasks done
andrea-marchionni opened this issue Sep 9, 2024 · 8 comments
Closed
8 tasks done
Labels
nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Milestone

Comments

@andrea-marchionni
Copy link

andrea-marchionni commented Sep 9, 2024

Environment variables written using agent.set_env() are stored in NS8 Redis and are readable by everyone. We need to avoid to use agent.set_env() for sensitive variables.

One Proposed solution is to write configuration to a json file, backup it, and write configuration to environment on module configure.
Another solution is to use core functions read_envfile/write_envfile, to store sensitive variables.

Implementing this will probably cause regressions in installation, backup and restore, migration from 7 and move/clone from node to node.

Actions to modify:

  • create-module
  • configure-module
  • update-module
  • import-module
  • transfert-state (seems nothing to do, we just stop services)
  • clone-module
  • restore-module
  • bin
@Amygos
Copy link
Member

Amygos commented Oct 8, 2024

NethVoice testing release: 1.0.3-testing.3

@Amygos
Copy link
Member

Amygos commented Oct 8, 2024

Nethvoice Proxy testing release: 1.0.2-testing.2

@Amygos Amygos added the testing Packages are available from testing repositories label Oct 8, 2024
@Amygos Amygos self-assigned this Oct 8, 2024
@Amygos
Copy link
Member

Amygos commented Oct 8, 2024

Test Case 1: Verify that a new installation of NethVoice testing version works correctly

Description: Ensure that NethVoice functions correctly after a fresh installation in the testing version.
Pre-conditions:

  • A fresh installation of the NethVoice testing version is available.
  • The installation is performed on a compatible system.

Steps:

  1. Install the NethVoice testing version.
  2. Follow the standard installation steps for the module.
  3. Open NethVoice after installation.
  4. Verify that all basic features (login, main page, settings) function correctly.

Expected Result: NethVoice testing version should work without any errors after installation.
Post-conditions: None.


Test Case 2: Verify that an update to NethVoice testing version functions correctly

Description: Ensure that updating NethVoice from a previous version to the testing version works without issues.
Pre-conditions:

  • The previous version of NethVoice is installed.
  • The update module for the new testing version of NethVoice is available.

Steps:

  1. Perform the update from the previous version to the NethVoice testing version.
  2. Open NethVoice after the update.
  3. Verify that existing data and settings are retained.
  4. Test core features (login, user data, settings) to ensure functionality.

Expected Result: The update to the NethVoice testing version should be successful, and all features should work as expected.
Post-conditions: None.


Test Case 3: Verify the migration of NethVoice to another node in testing version

Description: Ensure that NethVoice can be migrated to another node without issues in the testing version and that it is reconfigured correctly.
Pre-conditions:

  • NethVoice is installed and running on the current node in the testing version.
  • The target node is ready for migration.

Steps:

  1. Prepare the target node for migration.
  2. Initiate the migration process from the current node to the target node.
  3. Verify that all data and settings are transferred correctly.
  4. Reconfigure NethVoice on the target node to ensure proper functionality.
  5. Open NethVoice on the target node and verify that all features function correctly.

Expected Result: NethVoice testing version should function correctly on the target node with all data and settings intact after migration and reconfiguration.
Post-conditions: None.


Test Case 4: Verify the backup/restore procedure of NethVoice testing version

Description: Ensure that the backup and restore procedures for NethVoice work correctly in the testing version.
Pre-conditions:

  • NethVoice testing version is installed and running.
  • A backup of NethVoice is available.

Steps:

  1. Perform a backup of the current NethVoice configuration and data.
  2. Verify that the backup is created successfully.
  3. Restore NethVoice from the backup.
  4. Open NethVoice after the restore and verify that all data and settings are intact.

Expected Result: The backup and restore procedures should work correctly in the testing version, with no data loss or errors.
Post-conditions: None.


Test Case 5: Verify migration from NetServer 7 to NethVoice testing version

Description: Ensure that migrating from NetServer 7 to NethVoice testing version is successful and functional.
Pre-conditions:

  • A working installation of NetServer 7 is available.
  • The migration module for NethVoice testing version is ready.

Steps:

  1. Prepare for migration from NetServer 7 to NethVoice testing version.
  2. Initiate the migration process.
  3. Verify that all relevant data and configurations are transferred to NethVoice.
  4. Open NethVoice after migration and check that all features function as expected.

Expected Result: Migration from NetServer 7 to NethVoice testing version should be successful, with all features working properly.
Post-conditions: None.

@Amygos
Copy link
Member

Amygos commented Oct 8, 2024

Execute the Test Case: 1,2,3 for NethVoice Proxy

@andrea-marchionni
Copy link
Author

andrea-marchionni commented Oct 11, 2024

Test Case: 1,2,3 for NethVoice and NethVoice Proxy ok

@andrea-marchionni
Copy link
Author

Test case 4 for NethVoice ok

@andrea-marchionni andrea-marchionni added verified All test cases were verified successfully and removed testing Packages are available from testing repositories labels Oct 11, 2024
@Amygos
Copy link
Member

Amygos commented Oct 11, 2024

@Amygos
Copy link
Member

Amygos commented Oct 11, 2024

@Amygos Amygos closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this from Verified to Done in NethVoice Oct 11, 2024
@Amygos Amygos removed the bug label Nov 7, 2024
@Amygos Amygos added this to the NethVoice 1.0 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nethvoice Bug or features releted to the NethVoice project verified All test cases were verified successfully
Projects
Archived in project
Development

No branches or pull requests

3 participants