-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nethvoice, Nethvoice-proxy: Don't use NS8's default environment for sensitive data #7011
Comments
NethVoice testing release: 1.0.3-testing.3 |
Nethvoice Proxy testing release: 1.0.2-testing.2 |
Test Case 1: Verify that a new installation of NethVoice testing version works correctlyDescription: Ensure that NethVoice functions correctly after a fresh installation in the testing version.
Steps:
Expected Result: NethVoice testing version should work without any errors after installation. Test Case 2: Verify that an update to NethVoice testing version functions correctlyDescription: Ensure that updating NethVoice from a previous version to the testing version works without issues.
Steps:
Expected Result: The update to the NethVoice testing version should be successful, and all features should work as expected. Test Case 3: Verify the migration of NethVoice to another node in testing versionDescription: Ensure that NethVoice can be migrated to another node without issues in the testing version and that it is reconfigured correctly.
Steps:
Expected Result: NethVoice testing version should function correctly on the target node with all data and settings intact after migration and reconfiguration. Test Case 4: Verify the backup/restore procedure of NethVoice testing versionDescription: Ensure that the backup and restore procedures for NethVoice work correctly in the testing version.
Steps:
Expected Result: The backup and restore procedures should work correctly in the testing version, with no data loss or errors. Test Case 5: Verify migration from NetServer 7 to NethVoice testing versionDescription: Ensure that migrating from NetServer 7 to NethVoice testing version is successful and functional.
Steps:
Expected Result: Migration from NetServer 7 to NethVoice testing version should be successful, with all features working properly. |
Execute the Test Case: 1,2,3 for NethVoice Proxy |
Test Case: 1,2,3 for NethVoice and NethVoice Proxy ok |
Test case 4 for NethVoice ok |
NethVoice released https://github.com/nethesis/ns8-nethvoice/releases/tag/1.0.3 |
NethVoice Proxy released https://github.com/nethesis/ns8-nethvoice-proxy/releases/tag/1.0.2 |
Environment variables written using agent.set_env() are stored in NS8 Redis and are readable by everyone. We need to avoid to use agent.set_env() for sensitive variables.
One Proposed solution is to write configuration to a json file, backup it, and write configuration to environment on module configure.
Another solution is to use core functions read_envfile/write_envfile, to store sensitive variables.
Implementing this will probably cause regressions in installation, backup and restore, migration from 7 and move/clone from node to node.
Actions to modify:
The text was updated successfully, but these errors were encountered: