feat: add ephemeral_storage parameter for Batch (Fargate-only) #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2024 17:18
Fix some documentation for other params
|
I have the correct permissions now, and this gives a batch job with ephemeral storage as expected when run |
|
Mergeable anytime from my end -- no impact on core. |
saikonen
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1738.
Please note I have not been able to test this for real as I don't have the right permissions in our AWS environment yet, but these are the parameters the code gives to the
register_job_definitioncall:{'type': 'container', 'containerProperties': {'image': 'public.ecr.aws/docker/library/python:3.11', 'jobRoleArn': 'arn:aws:iam::xxxx', 'command': ['echo', 'hello world'], 'resourceRequirements': [{'value': '1', 'type': 'VCPU'}, {'value': '4096', 'type': 'MEMORY'}], 'executionRoleArn': 'arn:aws:iam::xxxx', 'networkConfiguration': {'assignPublicIp': 'ENABLED'}, 'ephemeralStorage': {'sizeInGiB': 50}}, 'propagateTags': True, 'platformCapabilities': ['FARGATE'], 'jobDefinitionName': 'metaflow_xxxx'}Also fixes some documentation for the tempfs parameter, and clarifies where this parameter can be used.