This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
Wallet revamp [WIP] #772
Open
Secretmapper
wants to merge
104
commits into
NebulousLabs:master
Choose a base branch
from
Secretmapper:develop/ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Wallet revamp [WIP] #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add reload and inspector tools
(really?)
(Original test fails)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revamp are a bunch of UI/UX changes to make it more consistent, modern, pretty, and presents a simpler onboarding process for wallet creation/restoration.
There are still a ton of work needed, but it's a good startoff and figured to post a PR to have early feedback from the core team as the changes are pretty substantial.
A lot of changes as well on the underlying tech. I bumped React to 16, Enzyme to 3, and used css vars. If css vars are more consistently applied to existing styles we might even have/add support for dark mode/alternate themes in the future