Skip to content

Commit

Permalink
Updated workflows to set LUSTRE_VERSION since it doesn't use the make…
Browse files Browse the repository at this point in the history
…file
  • Loading branch information
bdevcich committed Feb 10, 2025
1 parent a328e7c commit e1e0775
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ jobs:
push: true
target: production
tags: ${{ steps.meta.outputs.tags }}
build-args: LUSTRE_VERSION=cray-2.15.B19

- name: "Build the final Docker image in nektos/act"
# The docker/build-push-action does actions/checkout, and that can't be
Expand Down Expand Up @@ -152,6 +153,7 @@ jobs:
push: true
target: debug
tags: ${{ steps.meta.outputs.tags }}
build-args: LUSTRE_VERSION=cray-2.15.B19

create_release:
needs: production
Expand Down
12 changes: 9 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,25 @@ IMAGE_TAG_BASE ?= ghcr.io/nearnodeflash/nnf-mfu
# tools. (i.e. podman)
CONTAINER_TOOL ?= docker

# Which tag to pull from the cray lustre source code.
# **Note:** This must also be set in .github/workflows/main.yaml for both
# production and debug docker builds.
CRAY_LUSTRE_VERSION ?= cray-2.15.B19

RPM_PLATFORM ?= linux/amd64
# Only support linux/amd64 builds. This reduces complexity with installing
# lustre, which is an option enabled for mpifileutils.
PLATFORM ?= linux/amd64

docker-build: VERSION ?= $(shell cat .version)
docker-build: TARGET ?= production
docker-build: .version
${CONTAINER_TOOL} build --platform=$(RPM_PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .
${CONTAINER_TOOL} build --platform=$(PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .

docker-build-debug: VERSION ?= $(shell cat .version)
docker-build-debug: TARGET ?= debug
docker-build-debug: IMAGE_TAG_BASE := $(IMAGE_TAG_BASE)-debug
docker-build-debug: .version
${CONTAINER_TOOL} build --platform=$(RPM_PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .
${CONTAINER_TOOL} build --platform=$(PLATFORM) --target $(TARGET) --build-arg LUSTRE_VERSION=${CRAY_LUSTRE_VERSION} -t $(IMAGE_TAG_BASE):$(VERSION) .

docker-push: VERSION ?= $(shell cat .version)
docker-push: .version
Expand Down

0 comments on commit e1e0775

Please sign in to comment.