Update egui to 0.27.2 #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Let's keep egui inside the workspace just for now to keep the same "flow". I will think about moving it outside of the workspace for 1.0 rework because it seems that egui is one of the most updated, used and "problematic" deps, so it kind of makes sense to make have it as a crate that doesn't depend on the notan's core. I am merging this as it is, but I am changing it afterwards, it seems I cannot push commits to this branch. Thanks!! |
|
No worries! Happy to help you maintain egui portion more if you wish as I use notan exclusively across a fair few projects with egui. Happy to chat on Discord about it too if you wish user is apekros |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates notan-egui to use egui 0.27.2, I also separated the version of the notan-egui crate from the workspace version, as I didn't think it made sense to update it when there are no changes to the main crate itself, happy to revert that though and just bump all.