fix: empty path
in selected assets + added augementAssetsInfo
and resolveWhenDismissed
options
#581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was wrong and would end up with empty path. The reason is that the path field was set after an async iOS method without awaiting with a promise. The timeout fix was not an actual fix.It would fail in many cases (slow device, too many item selected).
Now we use an async and await, thus we can remove the setTimeout.
Also added :
augementAssetsInfo
to allow for faster selection in many cases (no video selection for example) where thumbnail, copyToAppFolder, or filesize are not neededresolveWhenDismissed
to wait for dismiss before resolving. important to be allowed to show another modal without the need of a dangerous setTimeout.Please test this before any release