Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only install corresponding abi package when possible #5635

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: only install corresponding abi package when possible #5635

wants to merge 9 commits into from

Commits on Feb 20, 2022

  1. feat: only install corresponding abi package when possible

    @farfromrefug
    farfromrefug committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    b808ea9 View commit details
    Browse the repository at this point in the history

  2. fix: better copyAppPackages handle

    @farfromrefug
    farfromrefug committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    dc30ac3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Merge branch 'master' of github.com:NativeScript/nativescript-cli int… 

    …o install_abi_package
    @farfromrefug
    farfromrefug committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    045ae6f View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. fix(android): in case we use buildFilterDevicesArch check if we nee… 

    …d to rebuild for devices we are building for
    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fb32803 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'nativescript/main' into install_abi_pac… 

    …kage

# Conflicts:
#	lib/controllers/build-controller.ts
#	lib/services/device/device-install-app-service.ts
    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    1b4357e View commit details
    Browse the repository at this point in the history

  3. feat: filterDevicesArch option to build only abi of connected devic… 

    …es for `run|debug`

this passes a gradle `abiFilters` arg to the build process which could allow the gradle config to only build abis of connected devices.
* build faster
* could be used with split to only deploy a smaller apk to each device depending on its abi

Default to false for now. Could become the default later

It requires an update to the gradle file in the android runtime
    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    35788f0 View commit details
    Browse the repository at this point in the history

  4. chore: fix after merge 

    # Conflicts:
#	lib/definitions/android-plugin-migrator.d.ts
    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c74f66b View commit details
    Browse the repository at this point in the history

  5. fix: filter for emulator only

    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7fa6662 View commit details
    Browse the repository at this point in the history

  6. chore: default filterDevicesArch to true

    @farfromrefug
    farfromrefug committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    9a52852 View commit details
    Browse the repository at this point in the history