chore: TypeScript 5.1 with Nx 16.6 migrations (#10338)

Author: NathanWalker

.eslintrc.json

@@ -1,12 +1,12 @@
 {
 	"root": true,
 	"ignorePatterns": ["**/*"],
-	"plugins": ["@nrwl/nx"],
+	"plugins": ["@nx"],
 	"overrides": [
 		{
 			"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
 			"rules": {
-				"@nrwl/nx/enforce-module-boundaries": [
+				"@nx/enforce-module-boundaries": [
 					"error",
 					{
 						"enforceBuildableLibDependency": true,
@@ -23,7 +23,7 @@
 		},
 		{
 			"files": ["*.ts", "*.tsx"],
-			"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier", "plugin:@nrwl/nx/typescript"],
+			"extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended", "prettier", "plugin:@nx/typescript"],
 			"rules": {
 				"no-empty": "off",
 				"no-useless-escape": "off",
@@ -43,14 +43,19 @@
 		},
 		{
 			"files": ["*.js", "*.jsx"],
-			"extends": ["plugin:@nrwl/nx/javascript"],
+			"extends": ["plugin:@nx/javascript"],
 			"rules": {}
 		},
 		{
 			"files": ["references.d.ts"],
 			"rules": {
 				"@typescript-eslint/triple-slash-reference": "off"
 			}
+		},
+		{
+			"files": "*.json",
+			"parser": "jsonc-eslint-parser",
+			"rules": {}
 		}
 	]
 }

.vscode/settings.json

@@ -1,10 +1,10 @@
-// Place your settings in this file to overwrite default and user settings.
 {
-    "search.exclude": {
-        "**/node_modules": true,
-        "**/bower_components": true,
-        "**/platforms": true,
-        "**/*.js": true,
-        "**/*.js.map": true
-    }
-}
+	"search.exclude": {
+		"**/node_modules": true,
+		"**/bower_components": true,
+		"**/platforms": true,
+		"**/*.js": true,
+		"**/*.js.map": true
+	},
+	"eslint.validate": ["json"]
+}

apps/automated/package.json

@@ -15,7 +15,7 @@
     "@nativescript/ios": "~8.5.0",
     "@nativescript/webpack": "file:../../dist/packages/nativescript-webpack.tgz",
     "circular-dependency-plugin": "^5.2.2",
-    "typescript": "~4.9.5"
+    "typescript": "5.1.6"
   },
   "gitHead": "c06800e52ee1a184ea2dffd12a6702aaa43be4e3",
   "readme": "NativeScript Application"

apps/automated/src/pages/package.json

@@ -1,4 +1,4 @@
 {
-    "name": "testsapp",
-    "main": "app.js"
+	"name": "testsapp",
+	"main": "app.js"
 }

apps/automated/src/ui/lifecycle/package.json

@@ -1,3 +1,3 @@
 {
-    "main": "lifecycle-tests"
+	"main": "lifecycle-tests"
 }

apps/automated/src/ui/repeater/repeater-tests.ts

@@ -474,15 +474,15 @@ export var test_RepeaterItemsGestureBindings = function () {
 	helper.navigateToModuleAndRunTest('ui/repeater/repeaterItems-bindingToGestures-page', null, testFunc);
 };
 
-export var test_RepeaterItemsParentBindingsShouldWork = function () {
+export var test_RepeaterItemsBindingsShouldWork = function () {
 	var testFunc = function (page: Page) {
 		var repeater = <Repeater>page.getViewById('repeater');
-		var expectedText = page.bindingContext['parentViewProperty'];
-		var testPass = false;
+		var expectedText = page.bindingContext['items'];
+		var testPass: string;
 		var eachChildCallback = function (childItem: View) {
 			if (childItem instanceof Label) {
-				testPass = (<Label>childItem).text === expectedText;
-				if (testPass === false) {
+				testPass = (<Label>childItem).text;
+				if (!testPass) {
 					return false;
 				}
 			} else if (childItem instanceof LayoutBase) {
@@ -494,7 +494,7 @@ export var test_RepeaterItemsParentBindingsShouldWork = function () {
 
 		repeater.eachChildView(eachChildCallback);
 
-		TKUnit.assertEqual(testPass, true, 'Every item should have text bound to Page binding context!');
+		TKUnit.assertEqual(!!testPass, true, 'Every item should have text bound to binding context!');
 	};
 
 	helper.navigateToModuleAndRunTest('ui/repeater/repeaterItems-bindingToGestures-page', null, testFunc);

apps/automated/src/ui/repeater/repeaterItems-bindingToGestures-page.ts

@@ -1,4 +1,4 @@
-function pageLoaded(args) {
+export function pageLoaded(args) {
 	var page = args.object;
 	page.bindingContext = {
 		items: [
@@ -18,8 +18,3 @@ function pageLoaded(args) {
 		parentViewProperty: 'Parent View Property',
 	};
 }
-exports.pageLoaded = pageLoaded;
-
-exports.tapPage = function (args) {
-	console.log('Tap! ' + args + ' ' + args.object);
-};

apps/automated/src/ui/repeater/repeaterItems-bindingToGestures-page.xml

@@ -1,8 +1,8 @@
 <Page xmlns="http://schemas.nativescript.org/tns.xsd" loaded="pageLoaded">
 	<Repeater id="repeater" items="{{ items }}">
 		<Repeater.itemTemplate>
-			<GridLayout width="94" height="94" >
-				<Label text="{{ $parents['Page'].parentViewProperty }}" tap="{{ tapItem }}" />
+			<GridLayout width="94" height="94">
+				<Label text="{{ text }}" tap="{{ tapItem }}" />
 			</GridLayout>
 		</Repeater.itemTemplate>
 	</Repeater>

apps/automated/src/ui/root-view/mymodule/package.json

@@ -1,4 +1,4 @@
 {
-    "name": "MyControl",
-    "main": "MyControl.js"
+	"name": "MyControl",
+	"main": "MyControl.js"
 }

apps/automated/src/xml-declaration/mymodulewithxml/package.json

@@ -1,4 +1,4 @@
 {
-    "name": "MyControl",
-    "main": "MyControl.js"
+	"name": "MyControl",
+	"main": "MyControl.js"
 }