Practicum

This practicum was designed to test some of your skills including: working with Github, Angular, NgRx and clean code practices.

You will start by duplicating the repository, then fixing few bugs, adding a simple feature, and finaly duing some code reivew.

⚠️ Please read the following instuctions carfully

Part 1: Setting up your repository

1. First you need to create a new GitHub ⚠️ private ⚠️ repository
2. Next, please duplicate this repository to your newly created one you can follow these instructions how to duplicate a repository

⚠️ Do not fork . If you do you will not be able to change the repo to private

How to submit 🚀

For each bug and feature (part 2) create new pull request (4 PRs in total). We suggest to name the branches something like fix\bug-<N>\<...> and feat\<...>.

⚠️ Please create a new branches for every fix and feature.

when you are done create a pull request for each branch that we will be use to review and discuss your work. Do not merge the pull requests

Part 2: Bugs & Feature

In this part you are required to fix 3 bugs and implement 1 feature.

Reminder: create a new branch and open a new PR for each bug and feature.

• Bug fixing (15 points x 3)

  Each bug designed to test a different Angular skill. You will find all the information and instructions in each issue:

  🪲 Bug #1

  🪲 Bug #2

  🪲 Bug #3

  💡 Hint: Bug 2 and Bug 3 can be fixed with 1-3 lines of code each, try to think about the simplest way to fix them. If a bug takes you more then 30min consider moving on to the next task.

• New feature (20 points)

  ✨ you are required to implement a global notification. In this feature request you will find all the requirements and an example.

⚠️ Do not use any external library. In this part we are interested in seeing your code.

Part 3: Code review (20 points) 👀

Lastly, in this part you are required to do a quick code review. Our goal is to see if you can recognize all the problematic and "smelly" code issues.

• Instructions:

  1. Create a new pull request of code-review-task into main branch
  2. Navigate to that pull request and add your review as comments

• 💡 Tips:

  • In your daly work you will create code review request and you will review other developers code. Think of this as a real review you are doing to one of your co-workers.
  • You are NOT required to understand or refactor the logic, you just need to suggest the developer what you think he should do to improve the quality of his code.
  • You don't need to repeat the same comment in each line you find the same problem, Single example for each issue you find is sufficient.

When you done

Please give [email protected] and [email protected] access to your private repo.

To Compile:

using yarn

run the project install the dependencies by running the command yarn and to run the development server use yarn start

Good luck!