Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

xoxor4d
Copy link
Contributor

@xoxor4d xoxor4d commented Mar 19, 2025

This is one part of the PR that covers both the bridge and the runtime. The runtime PR can be found here:
tba ...

This PR implements two new API methods: AddTextureHash and RemoveTextureHash.
These can be used to add or remove individual texture hashes from texture category options (hash sets).
The SetConfigVariable is not practical in that regard as it only allows to set the entire option to the specified value and would require the user to craft the entire hash set string.

Example use cases:

  • Some effect or similar that is using texture XY is causing issues on a certain map and has to be hidden. But texture XY is also used in other parts of the game where it does not cause issues.
  • Multiplayer/Coop games where the player character is visible in first person view (and tagged as player body) to allow for shadows or virtual instances (Portal) but the player model changes based on the class/team etc. Prime example would be Portal 2 Coop where two different player models are in use. The two methods allow me to dynamically set/remove the player body texture hashes depending on which character you play.

Notheworthy changes:

  • increased REMIXAPI_VERSION_MINOR from 5 to 6

Included fixes:

2025-03-18.21-25-29.mp4
if (ImGui::Button("Add Hash")) {
	remix_api::get()->m_bridge.AddTextureHash("rtx.ignoreTextures", "0x990C1CCB42F806E0");
}
if (ImGui::Button("Remove Hash")) {
	remix_api::get()->m_bridge.RemoveTextureHash("rtx.ignoreTextures", "0x990C1CCB42F806E0");
}

also fixes #727 (NVIDIAGameWorks/rtx-remix#727)

- increased REMIXAPI_VERSION_MINOR from 5 to 6
@nv-ajaus
Copy link
Collaborator

Hi @xoxor4d, I see that this PR includes a bug-fix that may resolve the issue with NVIDIAGameWorks/rtx-remix#736. Would it be possible to break the bugfix out into it's own commit and PR?

@xoxor4d
Copy link
Contributor Author

xoxor4d commented Apr 12, 2025

Hi @xoxor4d, I see that this PR includes a bug-fix that may resolve the issue with NVIDIAGameWorks/rtx-remix#736. Would it be possible to break the bugfix out into it's own commit and PR?

Sure! Here it is: #20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants