Fix sphn API compatibility with Kyutai Labs implementation#44
Open
CharlesMcquade wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fix sphn API compatibility with Kyutai Labs implementation#44CharlesMcquade wants to merge 1 commit intoNVIDIA:mainfrom
CharlesMcquade wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The sphn package from PyPI (Kyutai Labs version) uses a different API than what PersonaPlex originally expected: - OpusStreamReader.append_bytes(bytes) -> returns np.ndarray PCM immediately - OpusStreamWriter.append_pcm(pcm) -> returns bytes Opus data immediately This fix updates server.py to use the correct streaming API by: 1. Buffering incoming Opus bytes in a queue 2. Processing queue items with append_bytes() and capturing returned PCM 3. Capturing Opus bytes returned from append_pcm() instead of calling read_bytes() This resolves the AttributeError crashes on client connections: - 'OpusStreamReader' object has no attribute 'read_pcm' - 'OpusStreamWriter' object has no attribute 'read_bytes' Tested with sphn 0.1.4 from PyPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sphn package from PyPI (Kyutai Labs version) uses a different API than what PersonaPlex originally expected:
This fix updates server.py to use the correct streaming API by:
This resolves the AttributeError crashes on client connections:
Tested with sphn 0.1.4 from PyPI.