[stateHandling] Remove swap semantics optimization support. #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows the latest design change for ownership management of state objects.
Remove the support for "move semantics" to allow the logical lifetime of a
state object to escape into called functions and the swapping of any
resources it may contain.
- remove the move constructor from qvector
- remove move attribute from init_state op
- remove explicit test for move semantics
- simplify the handling of init_state data: it has to be a pointer
to a supported data type, floating-point, complex, or state.
annagrin
approved these changes
May 24, 2024
schweitzpgi
merged commit 24accba
into
NVIDIA:experimental/stateHandling
125 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows the latest design change for ownership management of state objects. Remove the support for "move semantics" to allow the logical lifetime of a state object to escape into called functions and the swapping of any resources it may contain.
Description