Fix mismatches between input state and simulation engine precision. #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schweitzpgi
force-pushed
the
ch-sim.format.sync
branch
from
2add1e5
to
436193c
Compare
amccaskey
reviewed
May 15, 2024
schweitzpgi
force-pushed
the
ch-sim.format.sync
branch
from
c6267e7
to
5169d4d
Compare
1tnguyen
approved these changes
May 15, 2024
It may be the case that the state vector data is in a precision that does not match that of the simulator. The runtime library knows precisely what simulator has been selected and can therefore convert the state vector to the expected format at runtime. This conversion may be *expensive* if the state vector is quite long. As a result, the runtime may want to emit a warning when a conversion path is taken. The following conversions happen at runtime with this change: vector<float> -> vector<complex<float>> vector<float> -> vector<complex<double>> vector<double> -> vector<complex<float>> vector<double> -> vector<complex<double>> vector<complex<float>> -> vector<complex<double>> vector<complex<double>> -> vector<complex<float>> If the input is vector<complex<float>> or vector<complex<double>> and the simulator's precision is a precise match, no conversions or runtime overhead is incurred. Fix NVIDIA#1670
schweitzpgi
force-pushed
the
ch-sim.format.sync
branch
from
5169d4d
to
5e8c63c
Compare
schweitzpgi
merged commit e0a2e98
into
NVIDIA:experimental/stateHandling
112 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be the case that the state vector data is in a precision that does not match that of the simulator. The runtime library knows precisely what simulator has been selected and can therefore convert the state vector to the expected format at runtime. This conversion may be expensive if the state vector is quite long. As a result, the runtime may want to emit a warning when a conversion path is taken.
The following conversions happen at runtime with this change:
If the input is
vector<complex<float>>orvector<complex<double>>and the simulator's precision is a precise match, no conversions or runtime overhead is incurred.Fix #1670
Description