-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve qudit's spec and code comments. #1520
Open
boschmitt
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
boschmitt:improve_qudit_docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
April 16, 2024 11:52
9ae7dc2
to
1c34d91
Compare
boschmitt
requested review from
bettinaheim,
amccaskey and
bmhowe23
as code owners
April 16, 2024 11:52
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
April 16, 2024 12:16
1c34d91
to
df0c06f
Compare
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
amccaskey
reviewed
Apr 16, 2024
quantum operators. The mechanism for negation is via overloading of | ||
:code:`qudit<Levels>::operator!()`. | ||
|
||
In library mode, it is the runtime responsibilities to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see library-mode + MLIR mode as implementation details, and not something we need for this document.
amccaskey
reviewed
Apr 16, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
4 times, most recently
from
April 17, 2024 10:39
8eabe47
to
0e9248e
Compare
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
amccaskey
reviewed
Apr 17, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
April 18, 2024 09:46
0e9248e
to
20509bc
Compare
amccaskey
reviewed
Apr 23, 2024
amccaskey
reviewed
Apr 23, 2024
boschmitt
force-pushed
the
improve_qudit_docs
branch
2 times, most recently
from
April 23, 2024 22:20
dd3d743
to
27e589d
Compare
boschmitt
force-pushed
the
improve_qudit_docs
branch
2 times, most recently
from
May 30, 2024 23:25
e05844c
to
3484671
Compare
boschmitt
force-pushed
the
improve_qudit_docs
branch
from
May 31, 2024 00:46
3484671
to
721e2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at improving the specification of the
qudit
type. It defines constraints for such type in a language agnostic way, and them reword the current definition as an explanation of the implementation details of this type in the case of C++.