-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CUDAX] Terminate in managed_memory_resource::deallocate_async #3185
Open
pciolkosz
wants to merge
4
commits into
NVIDIA:main
Choose a base branch
from
pciolkosz:throw_in_managed_deallocate_async
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CUDAX] Terminate in managed_memory_resource::deallocate_async #3185
pciolkosz
wants to merge
4
commits into
NVIDIA:main
from
pciolkosz:throw_in_managed_deallocate_async
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟩 CI finished in 23m 25s: Pass: 100%/26 | Total: 2h 21m | Avg: 5m 25s | Max: 18m 42s | Hits: 82%/312
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 26)
# | Runner |
---|---|
18 | linux-amd64-cpu16 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
2 | linux-amd64-gpu-v100-latest-1 |
miscco
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this is the right approach, we rather want something liketerminate()
see nvbug5017698
pciolkosz
changed the title
[CUDAX] Throw in managed_memory_resource::deallocate_async
[CUDAX] Terminate in managed_memory_resource::deallocate_async
Dec 18, 2024
🟩 CI finished in 46m 27s: Pass: 100%/26 | Total: 2h 32m | Avg: 5m 52s | Max: 22m 35s | Hits: 82%/312
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 26)
# | Runner |
---|---|
18 | linux-amd64-cpu16 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
2 | linux-amd64-gpu-v100-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is fine to forward
allocate_async
toallocate
, it is invalid to forwarddeallocate_async
todeallocate
, since the memory might still be in use. This PR changesdeallocate_async
onmanaged_memory_resource
tothrowterminate, whilepinned_memory_resource
will be handled separately.