Skip to content

fix: update grad_output quant to avoid redundant work #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kshitij12345
Copy link

@kshitij12345 kshitij12345 commented Apr 30, 2025

Fixes #1693

@kshitij12345 kshitij12345 force-pushed the fixed-weight-grad-output-quant branch from cf0dd38 to 00667ec Compare April 30, 2025 10:10
@kshitij12345 kshitij12345 marked this pull request as ready for review April 30, 2025 10:11
@ksivaman
Copy link
Member

ksivaman commented May 5, 2025

/te-ci pytorch L0 L1

Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

ksivaman commented May 7, 2025

/te-ci pytorch L0 L1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MXFP8] grad_output is quantized columnwise even if weight doesn't require gradients.
2 participants