Skip to content

Move allreduce_strategy from committed api to reference #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Move allreduce_strategy from committed api to reference #5147

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452aab3
Move allreduce_strategy from committed api to reference
HuiGao-NV Jun 12, 2025
1772291
Remove one not used file
HuiGao-NV Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/unittest/api_stability/references/llm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ methods:
max_cpu_loras:
annotation: int
default: 4
allreduce_strategy:
annotation: Optional[Literal['AUTO', 'NCCL', 'UB', 'MINLATENCY', 'ONESHOT', 'TWOSHOT', 'LOWPRECISION', 'MNNVL']]
default: AUTO
kwargs:
annotation: Any
default: inspect._empty
Expand Down
3 changes: 0 additions & 3 deletions tests/unittest/api_stability/references_committed/llm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,6 @@ methods:
kv_cache_config:
annotation: tensorrt_llm.llmapi.llm_args.KvCacheConfig
default: null
allreduce_strategy:
annotation: Optional[Literal['AUTO', 'NCCL', 'UB', 'MINLATENCY', 'ONESHOT', 'TWOSHOT', 'LOWPRECISION', 'MNNVL']]
default: AUTO
return_annotation: None
generate:
parameters:
Expand Down