Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 69660 - #22156

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261112-012240
Open

trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20261112-012240

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch: main
Bug(s): 7083117

Waive entries added

unittest/_torch/modeling/test_musespark_open_finalize_local.py::test_modules_import_without_cute_dsl SKIP (https://nvbugs/7083117)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • The change adds one line to tests/integration/test_lists/waives.txt. No source code changes.
  • The entry sets SKIP for one test ID: unittest/_torch/modeling/test_musespark_open_finalize_local.py::test_modules_import_without_cute_dsl.
  • The skip scope is one test. No other tests change.
  • The skip removes CI coverage for the import path that this test checks. Import failures in that path are not caught until the waive is removed.
  • The waive references bug 7083117. Its removal depends on the fix for that bug.

QA Engineer Review

  • Test-list file changed: tests/integration/test_lists/waives.txt (modified, +1/-0).
  • Waiver added: SKIP for unittest/_torch/modeling/test_musespark_open_finalize_local.py::test_modules_import_without_cute_dsl, tracked under bug 7083117.
  • Behavior covered: module import without the CuTe DSL. This test no longer runs in CI while the waive is active.
  • Test-db and qa list placement does not apply to waivers.
  • Coverage verdict: needs follow-up. Confirm that bug 7083117 has an owner and a plan to remove the waive.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds a SKIP entry. The named test stops running in CI, so import regressions in the CuTe DSL-less path go undetected until the waive is removed.

Bug(s): 7083117
Requested by: @HuiGao-NV

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@HuiGao-NV

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive main breaks"

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The integration test skip list now includes the Musespark module-import test, marked SKIP with tracking issue 7083117.

Changes

Integration Test Skip List

Layer / File(s) Summary
Add Musespark test skip entry
tests/integration/test_lists/waives.txt
The skip list adds test_modules_import_without_cute_dsl with tracking issue 7083117.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: tburt-nv, lori-ren

Merge Risk: Minimal · up to e346c

This only skips one module-import unit test, tracked by an issue, and changes no product behavior. It is safe to merge.

Architecture risk: Low · up to e346c

The change affects 1 system.

Changed systems: tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/integration/test_lists/waives.txt: Adds the Musespark open/finalize local module-import test to the skip list, with issue 7083117.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change as a waive of one failed test case for main in pre-merge pipeline 69660, which matches the single added SKIP entry in tests/integration/test_lists/waives.txt. It follows the…
Description check Passed The description follows the repository's content structure only partly. It gives the auto-generated waive details: target branch main, bug link 7083117, and the added waive entry. It does not fill in …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change as a waive of one failed test case for main in pre-merge pipeline 69660, which matches the single added SKIP entry in tests/integration/test_lists/waives.txt. It follows the repository's [ticket][type] Summary style loosely, using [None][infra]. It is specific enough for a teammate scanning history to see the primary change.

Full details: Description check

Explanation

The description follows the repository's content structure only partly. It gives the auto-generated waive details: target branch main, bug link 7083117, and the added waive entry. It does not fill in the template's Description section explaining the issue and fix, the Test Coverage section, or the PR checklist. For a generated waive PR these gaps are minor, but the description is not a full match to the template.

Resolution

Consider adding a short Description explaining why the test fails and why skipping it is appropriate. Optionally fill in Test Coverage and mark the checklist as reviewed.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 762a8dc and e346c20.

Files selected for processing: 1

  • tests/integration/test_lists/waives.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 7 remain after this review.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #84302 [ skip ] triggered by Bot. Commit: e346c20 Link to invocation

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants