Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unexpected parameters directly on loading config #11688

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Drop unexpected parameters directly on loading config #11688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
136c338
Call drop_unexpected_params directly on loading config
janekl Dec 20, 2024
795b706
Remove auxiliary script
janekl Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nemo/lightning/io/mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def analyze(config: fdl.Config, prefix: str):
for param in to_drop:
del config.__arguments__[param]
else:
logging.info(f"Skip analyzing {prefix} as it accepts arbitrary keyword arguments.")
logging.debug(f"Skip analyzing {prefix} as it accepts arbitrary keyword arguments.")

# Proceed recursively for all arguments
for key, value in config.__arguments__.items():
Expand Down Expand Up @@ -791,6 +791,8 @@ def load(path: Path, output_type: Type[CkptType] = Any, subpath: Optional[str] =
config = serialization.Deserialization(json_config).result
_artifact_transform_load(config, path)

drop_unexpected_params(config)

if not build:
return config

Expand Down
94 changes: 0 additions & 94 deletions scripts/llm/update_io_context.py
View file
Open in desktop

This file was deleted.

Loading