Drop unexpected parameters directly on loading config (#11688)

* Call drop_unexpected_params directly on loading config Signed-off-by: Jan Lasek <[email protected]> * Remove auxiliary script Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]>
NVIDIA · Jan 3, 2025 · 0f08462 · 0f08462
1 parent c35877c
commit 0f08462
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 95 deletions.
diff --git a/nemo/lightning/io/mixin.py b/nemo/lightning/io/mixin.py
@@ -715,7 +715,7 @@ def analyze(config: fdl.Config, prefix: str):
                     for param in to_drop:
                         del config.__arguments__[param]
             else:
-                logging.info(f"Skip analyzing {prefix} as it accepts arbitrary keyword arguments.")
+                logging.debug(f"Skip analyzing {prefix} as it accepts arbitrary keyword arguments.")
 
             # Proceed recursively for all arguments
             for key, value in config.__arguments__.items():
@@ -791,6 +791,8 @@ def load(path: Path, output_type: Type[CkptType] = Any, subpath: Optional[str] =
     config = serialization.Deserialization(json_config).result
     _artifact_transform_load(config, path)
 
+    drop_unexpected_params(config)
+
     if not build:
         return config
 

diff --git a/scripts/llm/update_io_context.py b/scripts/llm/update_io_context.py