lazy load jailbreak detection dependencies #1223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cparisien
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
I'm ok with this. Will need @erickgalinkin to ensure current test coverage is sufficient.
erickgalinkin
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
This looks great to me! Thanks for the suggestion @jeffreyscarpenter !
tgasser-nv
requested changes
Jun 12, 2025
| @@ -71,6 +73,7 @@ def __call__(self, text: str): | |||
|
|
|||
| class JailbreakClassifier: | |||
| def __init__(self, random_forest_path: str): | |||
| from sklearn.ensemble import RandomForestClassifier | |||
| self.embed = SnowflakeEmbed() | |||
| with open(random_forest_path, "rb") as fd: | |||
| self.classifier = pickle.load(fd) | |||
There was a problem hiding this comment.
Nit: Should we include a pickle in the init() along with the RandomForestClassifier? My guess is scikit-learn imports it so we pick it up implicitly
|
|
||
| @lru_cache() | ||
| def initialize_model(classifier_path: str = models_path) -> JailbreakClassifier: | ||
| def initialize_model(classifier_path: str = models_path): |
There was a problem hiding this comment.
Nit: Could you add the return -type back in (as 'JailbreakClassifier' now we're importing this in the function)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1222 by making jailbreak detection dependencies lazy-loaded. This means torch, transformers, and sklearn are only imported when using the local model-based approach, not when using the NIM-based approach.
Related Issue(s)
Fixes #1222
Checklist