Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce Dataframe Backend Checks #514
base: main
Are you sure you want to change the base?
Enforce Dataframe Backend Checks #514
Changes from 11 commits
854a06a
056afe0
624bc91
1ecf5d9
75d571f
67ccaba
4e591de
42bf06e
bae1584
db2d115
bc6cc14
d41351e
575d695
6a7bf43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case for this? And also type hints for ddf which would be
dd.DataFrame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What part of this do you want to test? I'm not quite seeing which part of this you want me to isolate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As someone reading this, it's not obviously clear what will be the output of
.__module__.split(".")[0]
of the type of object's_meta
attribute. So I would've proposed that you move this to a function and have tests for that and use that function here.However I see you've changed this to is_cudf_type(..) which is much more readable, and now we can unittest that directly that.