benchmark readme updates #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lane <[email protected]>
ryantwolf
approved these changes
Jan 31, 2025
ayushdg
requested changes
Jan 31, 2025
There was a problem hiding this comment.
Thanks for the updates. Left one small comment inline.
Also for the second chart I have a couple of suggestions:
- Remove the red squiggly line on the y axis (hrs).
- Remove the
3in scaling on1,2,3,4nodes since the chart only has values for 1,2,4. Maybe also add that each node containers 8x H100 GPUs
Signed-off-by: Lawrence Lane <[email protected]>
Signed-off-by: Lawrence Lane <[email protected]>
ayushdg
approved these changes
Feb 7, 2025
philm001
pushed a commit
to philm001/NeMo-Curator
that referenced
this pull request
Feb 10, 2025
* benchmark readme updates Signed-off-by: Lawrence Lane <[email protected]> * benchmark image update Signed-off-by: Lawrence Lane <[email protected]> * benchmark text update Signed-off-by: Lawrence Lane <[email protected]> --------- Signed-off-by: Lawrence Lane <[email protected]> Signed-off-by: Phillip Mobley <[email protected]>
philm001
pushed a commit
to philm001/NeMo-Curator
that referenced
this pull request
Feb 10, 2025
* benchmark readme updates Signed-off-by: Lawrence Lane <[email protected]> * benchmark image update Signed-off-by: Lawrence Lane <[email protected]> * benchmark text update Signed-off-by: Lawrence Lane <[email protected]> --------- Signed-off-by: Lawrence Lane <[email protected]> Signed-off-by: Phillip Mobley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
benchmark readme updates
Checklist