Add Pooling Strategy Option for embedding creation #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
|
CC: @avem-nv to review |
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
sarahyurick
added
gpuci
sarahyurick
approved these changes
Feb 6, 2025
philm001
pushed a commit
to philm001/NeMo-Curator
that referenced
this pull request
Feb 10, 2025
* Add pooling stratedgy Signed-off-by: Vibhu Jawa <[email protected]> * Ensure pytest is importable in a CPU only environment Signed-off-by: Vibhu Jawa <[email protected]> * Fix last token based on Avinash's feedback Signed-off-by: Vibhu Jawa <[email protected]> * Fix indexing issues Signed-off-by: Vibhu Jawa <[email protected]> * Merge in main Signed-off-by: Vibhu Jawa <[email protected]> * Fix Doc-string Signed-off-by: Vibhu Jawa <[email protected]> * Address Sarah's reviews Signed-off-by: Vibhu Jawa <[email protected]> --------- Signed-off-by: Vibhu Jawa <[email protected]> Signed-off-by: Phillip Mobley <[email protected]>
philm001
pushed a commit
to philm001/NeMo-Curator
that referenced
this pull request
Feb 10, 2025
* Add pooling stratedgy Signed-off-by: Vibhu Jawa <[email protected]> * Ensure pytest is importable in a CPU only environment Signed-off-by: Vibhu Jawa <[email protected]> * Fix last token based on Avinash's feedback Signed-off-by: Vibhu Jawa <[email protected]> * Fix indexing issues Signed-off-by: Vibhu Jawa <[email protected]> * Merge in main Signed-off-by: Vibhu Jawa <[email protected]> * Fix Doc-string Signed-off-by: Vibhu Jawa <[email protected]> * Address Sarah's reviews Signed-off-by: Vibhu Jawa <[email protected]> --------- Signed-off-by: Vibhu Jawa <[email protected]> Signed-off-by: Phillip Mobley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes: #490