Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nemo-toolkit dependency to gpuCI #480

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −9
Open

Add nemo-toolkit dependency to gpuCI #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d2b709
Add nemo-toolkit dependency
sarahyurick Jan 10, 2025
0e834fd
add nemo-toolkit install to Dockerfile
sarahyurick Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ RUN conda create -y --name curator -c nvidia/label/cuda-${CUDA_VER} -c conda-for
libcusolver \
cuda-nvvm && \
source activate curator && \
pip install --upgrade pytest pip
pip install --upgrade pytest pip nemo-toolkit

RUN \
--mount=type=bind,source=/opt/NeMo-Curator/nemo_curator/__init__.py,target=/opt/NeMo-Curator/nemo_curator/__init__.py,from=curator-update \
Expand Down
10 changes: 2 additions & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ dependencies = [
"distributed>=2021.7.1",
"fasttext==0.9.3",
"ftfy==6.1.1",
"huggingface-hub",
"in-place==0.5.0",
"jieba==0.42.1",
"justext==3.0.1",
Expand All @@ -65,6 +66,7 @@ dependencies = [
"resiliparse",
"sentencepiece",
"spacy>=3.6.0, <3.8.0",
"tqdm",
# TODO: Remove this pin once newer version is released
"transformers==4.46.3",
"unidic-lite==1.0.8",
Expand Down Expand Up @@ -107,17 +109,9 @@ image_nightly = [
"timm>=1.0.8",
"nemo_curator[cuda12x_nightly]",
]
# Installs bitext curation modules
bitext = [
"huggingface-hub",
"tqdm",
"transformers",
"nemo_curator[cuda12x]",
]
Comment on lines -110 to -116
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #193 it does not look like the cuda12x dependencies are strictly needed here? Also, I believe all of huggingface-hub, tqdm, and transformers are already being installed either directly or indirectly.

# Installs all of the above with Stable RAPIDS
all = [
"nemo_curator[image]",
"nemo_curator[bitext]",
]
# Installs all of the above with RAPIDS Nightlies
all_nightly = [
Expand Down
Loading