Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ADD ID to work with CPU/GPU both #479

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Enable ADD ID to work with CPU/GPU both #479

wants to merge 6 commits into from

Conversation

VibhuJawa
Copy link
Collaborator

This PR fixes: #473

@VibhuJawa VibhuJawa requested a review from ayushdg January 10, 2025 18:28
@VibhuJawa VibhuJawa added the gpuci Run GPU CI/CD on PR label Jan 10, 2025
@VibhuJawa VibhuJawa added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Jan 10, 2025
@VibhuJawa VibhuJawa added gpuci Run GPU CI/CD on PR and removed gpuci Run GPU CI/CD on PR labels Jan 13, 2025
@sarahyurick sarahyurick mentioned this pull request Jan 22, 2025
Open
@sarahyurick
Copy link
Collaborator

Do you know if this could help fix #142?

@VibhuJawa
Copy link
Collaborator Author

Running into OOM with add id #142

I think if we just do the start_index=None it should be scalable as we pass it to _add_id_fast

@VibhuJawa VibhuJawa requested a review from sarahyurick February 5, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushdg ayushdg Awaiting requested review from ayushdg

@sarahyurick sarahyurick Awaiting requested review from sarahyurick

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
gpuci Run GPU CI/CD on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[IMP] Switch to GPU for add_id by default and make that setting configurable
2 participants
@VibhuJawa @sarahyurick