Add SSL support for Android Edge App #3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds SSL/HTTPS support to the Android Edge App, enabling secure communication with the NVFlare server. The changes allow users to configure HTTPS connections and handle self-signed certificates for development environments.
- Adds configurable SSL support with HTTPS scheme selection
- Implements self-signed certificate handling for development environments
- Updates UI to include SSL configuration switches
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Connection.kt | Core SSL implementation with configurable scheme and self-signed cert support |
| AndroidFlareRunner.kt | Minor type annotation update and whitespace cleanup |
| network_security_config.xml | Android network security configuration for cleartext and certificate handling |
| MainActivity.kt | UI switches for HTTPS and self-signed certificate options |
| FlareRunnerController.kt | SSL configuration properties and connection setup logic |
| AndroidManifest.xml | Network security configuration reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...device/android/app/src/main/java/com/nvidia/nvflare/app/controllers/FlareRunnerController.kt
Show resolved
Hide resolved
...device/android/app/src/main/java/com/nvidia/nvflare/app/controllers/FlareRunnerController.kt
Outdated
Show resolved
Hide resolved
|
/build |
nvflare/edge/device/android/app/src/main/res/xml/network_security_config.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Add one question, otherwise if you have tested with both http://xxx:yyy and https://xxx:yyy then we should be good.
|
/build |
|
I have tested that this works with both https and http |
YuanTingHsieh
approved these changes
Sep 10, 2025
|
/build |
chesterxgchen
pushed a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Sep 30, 2025
Add SSL support for Android Edge App ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SSL support for Android Edge App
Types of changes
./runtest.sh.