Hello-LR Update #3663
Merged
Hello-LR Update #3663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chesterxgchen
force-pushed
the
LR_data
branch
from
5bd8c7e to
645882a
Compare
|
/build |
1 similar comment
|
/build |
|
/build |
chesterxgchen
force-pushed
the
LR_data
branch
from
2ff8994 to
701b848
Compare
YuanTingHsieh
approved these changes
Sep 8, 2025
2) fix README.md and index.rst
chesterxgchen
force-pushed
the
LR_data
branch
from
bc20d6a to
70cabf8
Compare
|
/build |
zhijinl
approved these changes
Sep 8, 2025
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Sep 30, 2025
# Description ## Fix data download and preparation issue. **Issues**: 1) Flamby download data doesn't work consistently, in many cases, it refuse to to download as the it has cached configure indicating download completed, and abort the operation, even through the data is already gone or not available. Flamby download is very convoluded requires config setup and etc. As result, one can't not download and finish experiments 2) Even you manage to download, the Flamby Dataset class failed to load the data, as the datasets now contains many other data file which are in different formats. **Solution** 1) replace the Flamby download with directly download dataset from the source. Only extract the original processed the datasets. 2) pass the data_path directly to Flamby avoid convoluted steps. ## Update doc update README and documentation hello-lr/index.rst file ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix data download and preparation issue.
Issues:
Flamby download data doesn't work consistently, in many cases, it refuse to to download as the it has cached configure indicating download completed, and abort the operation, even through the data is already gone or not available.
Flamby download is very convoluded requires config setup and etc.
As result, one can't not download and finish experiments
Even you manage to download, the Flamby Dataset class failed to load the data, as the datasets now contains many other data file which are in different formats.
Solution
Update doc
update README and documentation hello-lr/index.rst file
Types of changes
./runtest.sh.