CC provision with docker image workload #3639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Docker image workload support for CC (Confidential Computing) provision to provide a generic way to accommodate different applications. The changes enable building Docker images for each participant during the provision process instead of relying on pre-installed packages.
- Adds a new DockerImageBuilder class to generate Dockerfiles and build scripts for each site
- Modifies the OnPremPackager to build Docker images during packaging
- Updates CC configuration to use workload images instead of pre-installed packages
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| nvflare/tool/code_pre_installer/install.py | Makes install_requirements function private by adding underscore prefix |
| nvflare/lighter/impl/docker_image_builder.py | New builder class that generates Dockerfiles and build scripts for each participant |
| nvflare/lighter/cc_provision/impl/onprem_packager.py | Adds Docker image building step to the packaging process |
| examples/advanced/cc_provision/project.yml | Updates configuration to use DockerImageBuilder and comments out cc_config |
| examples/advanced/cc_provision/cc_site-1.yml | Removes nvflare package installation config, adds workload_image specification |
| examples/advanced/cc_provision/cc_server1.yml | Removes nvflare package installation config, adds workload_image specification |
| examples/advanced/cc_provision/Dockerfile.base | Base Dockerfile template for building participant images |
Comments suppressed due to low confidence (1)
nvflare/lighter/cc_provision/impl/onprem_packager.py:1
- The function no longer returns result.stdout after the changes, but there may be callers expecting a return value. This could break existing functionality that depends on the command output.
# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
YuanTingHsieh
force-pushed
the
cc_provision_docker_image_workload
branch
from
1c504df to
2a4f577
Compare
|
@YuanTingHsieh any changes on this required with latest CC build scripts ( MR merged) |
YuanTingHsieh
force-pushed
the
cc_provision_docker_image_workload
branch
from
f2261d2 to
493ebbd
Compare
YuanTingHsieh
changed the title
YuanTingHsieh
force-pushed
the
cc_provision_docker_image_workload
branch
from
493ebbd to
b2b94bf
Compare
YuanTingHsieh
force-pushed
the
cc_provision_docker_image_workload
branch
2 times, most recently
from
b35ab63 to
f84fc66
Compare
YuanTingHsieh
force-pushed
the
cc_provision_docker_image_workload
branch
from
ae45536 to
7887fa4
Compare
|
/build |
|
/build |
chesterxgchen
approved these changes
Sep 19, 2025
|
/build |
1 similar comment
|
/build |
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Sep 30, 2025
CC provision with docker image workload for a generic way to accommodate different applications in the future ### Description CC provision with docker image workload for a generic way to accommodate different applications in the future ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated. --------- Co-authored-by: Chester Chen <[email protected]>
chesterxgchen
added a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Oct 11, 2025
CC provision with docker image workload for a generic way to accommodate different applications in the future ### Description CC provision with docker image workload for a generic way to accommodate different applications in the future ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated. --------- Co-authored-by: Chester Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC provision with docker image workload for a generic way to accommodate different applications in the future
Description
CC provision with docker image workload for a generic way to accommodate different applications in the future
Types of changes
./runtest.sh.