Add wait_for_device info and timeout #3632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiyueXu77
changed the title
6 tasks
YuanTingHsieh
requested changes
Aug 27, 2025
good point! will add an independent thread to trace the countdown |
6 tasks
|
/build |
|
/build |
YuanTingHsieh
approved these changes
Sep 10, 2025
|
/build |
chesterxgchen
pushed a commit
to chesterxgchen/NVFlare
that referenced
this pull request
Sep 30, 2025
Fixes QA 5477637 and 5477445. ### Description QA's question on waiting for sufficient device, I think it makes sense to add status printout to inform users and a timeout to limit the waiting time. Also regarding max_model_history, update to warning for reports that are "too stale", removed redundant check ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes QA 5477637 and 5477445.
Description
QA's question on waiting for sufficient device, I think it makes sense to add status printout to inform users and a timeout to limit the waiting time.
Also regarding max_model_history, update to warning for reports that are "too stale", removed redundant check
Types of changes
./runtest.sh.