Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content for logistic regression for DLI #3209

Merged
merged 5 commits into from
Feb 7, 2025

Conversation

nvkevlu
Copy link
Collaborator

@nvkevlu nvkevlu commented Feb 6, 2025

Add content for logistic regression for DLI.

Description

Add content for logistic regression for DLI.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvkevlu nvkevlu requested a review from ZiyueXu77 February 6, 2025 23:28
@nvkevlu nvkevlu enabled auto-merge (squash) February 7, 2025 01:30
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Feb 7, 2025

/build

"Using `nvflare`, The federated logistic regression with Newton-Raphson\n",
"optimization is implemented as follows.\n",
"\n",
"On the server side, all workflow logics are implemented in\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when explain the server side, we should let user to view the server side the code by using !cat bash command
so they are related to what we are describing

similarly to Client side. we should make this more interactive.
but for now this is fine. @zhijinl can add more if he feel there is time to do it

@nvkevlu nvkevlu merged commit 4c5948e into NVIDIA:main Feb 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants