Skip to content

Conversation

@naoyam
Copy link
Collaborator

@naoyam naoyam commented Mar 21, 2025

No description provided.

@naoyam
Copy link
Collaborator Author

naoyam commented Mar 21, 2025

!test --diff

@github-actions
Copy link

Description

  • Removed unnecessary IterType::GatherScatter usage

  • Simplified IterDomainBuilder in gather function


Changes walkthrough 📝

Relevant files
Enhancement
indexing.cpp
Simplify IterDomainBuilder usage                                                 

csrc/ops/indexing.cpp

  • Removed IterType::GatherScatter assignment in IterDomainBuilder
  • Simplified out_domain construction in gather function
  • +1/-7     

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🧪 No relevant tests
    ⚡ Recommended focus areas for review

    Performance Impact

    The change removes the specific IterType::GatherScatter setting for IterDomain. This might affect the performance of gather operations, especially if GatherScatter was used for optimization purposes.

    out_domain.push_back(IterDomainBuilder(idx_domain_ptr).build());

    @naoyam naoyam changed the title Don't use IterType::gatherscatter with gather [WIP] Don't use IterType::gatherscatter with gather Apr 4, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants