Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C API 2.0 error handling #5797

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jan 31, 2025

Category:

New feature (non-breaking change which adds functionality)

This PR adds error translation to the C API 2.0.

Description:

The errors are caught in a macro and translated to a status code and a message stored in TLS.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
include/dali/dali.h Outdated Show resolved Hide resolved
dali/c_api_2/init.cc Outdated Show resolved Hide resolved
dali/c_api_2/error_handling.cc Show resolved Hide resolved
@mzient mzient force-pushed the C_API2_error_handling branch 3 times, most recently from 6e3bd01 to 14aebea Compare February 13, 2025 11:57
Signed-off-by: Michał Zientkiewicz <[email protected]>
@mzient mzient force-pushed the C_API2_error_handling branch from 14aebea to 813dba7 Compare February 18, 2025 10:30
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24121150]: BUILD STARTED

Signed-off-by: Michal Zientkiewicz <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24127410]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24140989]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24127410]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24140989]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants