feat: add kl fix #524
Draft
feat: add kl fix #524
+28
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gerald Shen <[email protected]>
| @@ -20,6 +20,8 @@ loss_fn: | |||
| use_on_policy_kl_approximation: false | |||
| use_importance_sampling_correction: false | |||
| token_level_loss: true | |||
| # see https://arxiv.org/pdf/2506.09477 | |||
| use_correct_grad_kl: false | |||
There was a problem hiding this comment.
Let's call it 'tang_grad_kl' intsead of 'correct_grad_kl' to make it clear where it's coming from. Also, the paper has a few implementations. Could you specify which one you're using?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
do kl as prescribed in https://arxiv.org/pdf/2506.09477. not enabling it by default since it changes user's run