Ray Video Pipeline : Video Reader #775
Open
+3,681
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
abhinavg4
requested changes
Jul 11, 2025
There was a problem hiding this comment.
I think we majorly need to split this into 2 stages:
- Get file list from local/s3. (potentially decides which files are already processed, or it can be a seperate stage, preferred)
- Download that file and decode it (This stage is generally very intensive and where xenna shines, We will use nvencs and nvdecs for this later)
| data: Video = field(default_factory=Video) | ||
|
|
||
| @property | ||
| def fraction(self) -> float: |
There was a problem hiding this comment.
Why do we need these functions? Can't we just do
task.data.fraction... wherever required?
There was a problem hiding this comment.
we could, this is just to ease the layer of abstraction.
There was a problem hiding this comment.
Wait all this is wrong. I think it should be self.data.fraction and not self.video.fraction ?
…adStage to accept VideoTask. Enhance video reading capabilities with new tests for VideoReaderStage. Signed-off-by: Ao Tang <[email protected]>
…_read_example to include verbose argument. Signed-off-by: Ao Tang <[email protected]>
… additional metadata fields. Signed-off-by: Ao Tang <[email protected]>
Signed-off-by: Ao Tang <[email protected]>
- Introduced a new test package for tasks with an initial test suite for the video tasks module, including tests for the Clip, ClipStats, Video, VideoMetadata, and VideoTask classes. - Implemented various test cases to validate initialization, property calculations, metadata extraction, and size calculations. This enhances the testing coverage for video-related functionalities in the ray-curator project. Signed-off-by: Ao Tang <[email protected]>
- Expanded the test suite for the video tasks module by adding new test cases for the Clip, ClipStats, Video, VideoMetadata, and VideoTask classes. - Improved coverage for various functionalities including initialization, property calculations, and metadata extraction. This update strengthens the reliability of video-related features in the ray-curator project. Signed-off-by: Ao Tang <[email protected]>
Signed-off-by: Ao Tang <[email protected]>
Signed-off-by: Ao Tang <[email protected]>
abhinavg4
reviewed
Jul 18, 2025
| return "video_download" | ||
|
|
||
| def inputs(self) -> tuple[list[str], list[str]]: | ||
| return [], [] |
There was a problem hiding this comment.
this should be
["data"], ["input_video"] ?
abhinavg4
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the initial stage for video pipeline:
Also provide with the associated Unit Test
Usage
Checklist