-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update doctr instruction #79
Conversation
FWIW, forked repos will be supported once I finish drdoctr/doctr#343, assuming that you configure doctr for that repo. The main issue is if you configure a base repo then a fork cannot work, as Travis doesn't give forks or forked pull requests access to the secure environment variables for obvious reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this warning can be better represented via a warning block.
I also think the link from @asmeurer's #79 (comment) can be mentioned as well.
Co-Authored-By: Maksim Rakitin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Here are a couple of my suggestions.
Co-Authored-By: Maksim Rakitin <[email protected]>
Co-Authored-By: Maksim Rakitin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know. At least some directives will be confused by the lack of a blank line, as they will interpret the line beneath |
Sounds good, will do in the future. |
DOC: update doctr instruction
Reason: https://github.com/drdoctr/doctr/blob/0f19ff78c8239efcc98d417f36b0a31d9be01ba5/doctr/travis.py#L593
It's very hard to find in Travis log. Think need to mention in instruction.