Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructuring of PVade #64

Merged
merged 170 commits into from
Feb 27, 2025
Merged

Restructuring of PVade #64

merged 170 commits into from
Feb 27, 2025

Conversation

arswalid
Copy link
Collaborator

@arswalid arswalid commented Sep 24, 2024 •
edited
Loading

  • restructuring of IO, structure, and utilities foldes
  • renaming of files
  • branch created to sync all local changes
  • Build_FSI created for panel 2d

brookeslawski and others added 14 commits June 6, 2024 10:06
@brookeslawski
updating gitignore
0df7970
@brookeslawski
working first version of uniform and parabolic inflow velocity profile
53e4e93
@brookeslawski
working loglaw velocity profile
b751341
@eyoung55
black formatting one file
1725ca6
@eyoung55
change time_varying_inflow_bc (a bool) to time_varying_inflow_window …
d2c781b 
…(a float) over which vel goes from 0->u_ref
@eyoung55
move test for ramp_window outside inflow cases, clean up printing to …
f06f136 
…happen only once
@eyoung55
change default on z0 from 0.01 to 0.05, make time_varying_inflow_wind…
46d6729 
…ow a float that defines ramp up window
@eyoung55
new var names for tests, specify loglaw for panel test, specify parab…
7aaebc2 
…olic+coeff+ramp_up_window for flag
@brookeslawski
testing all the input files
48c9127
@brookeslawski
adding regression test to test that all files in input/ folder run
dc2f20c
@brookeslawski
changes to enable assertion-based pass/fail to reg test
3c843b0
@brookeslawski
2d input file tests still failing
016280e
@arswalid
Build_FSI created for panel 2d
f13e7d2 
- restructuring of IO, structure, and utilities foldes
- renaming of files
- branch created to sync all local changes
@arswalid
fixing pytest
63467de
@eyoung55 eyoung55 self-assigned this Oct 3, 2024
@eyoung55 eyoung55 added this to the FY24 Release milestone Oct 7, 2024
@arswalid arswalid changed the title Build_FSI created for panel 2d Restructuring of PVade Oct 8, 2024
@arswalid arswalid modified the milestones: FY24 Release, FY25 release Oct 29, 2024
eyoung55 and others added 26 commits December 12, 2024 17:01
@eyoung55
Merge branch 'sync' of https://github.com/NREL/PVade into HEAD
853cfb8
@eyoung55
black format 2 more files
79a573e
@eyoung55
ndim=None marks uninitialized ndim, and change input.yaml solve 4 option
8875e16
@eyoung55
typo, test should be for 3d
944789b
@eyoung55
update test solve for thermal option
1304525
@brookeslawski
changed thermal_analysis default to false and fixed test_input_files.py
e12641b
@brookeslawski
switching back to mpirun in test_input_fies.py
cc35071
@brookeslawski
test_solve still not working, flag2d structural solve to true
b01f618
@brookeslawski
using pre-generated mesh
f89d806
@arswalid
fixing bc's for 2d and 3d panel
7136616
@arswalid
black formating
90842df
@arswalid
rectification zmin for top and bottom
e204cf2
@arswalid
zmin addition top top and bottom for 2D
8700273
@arswalid
black formatting
711e22e
@eyoung55
black formatting
10308df
@eyoung55
compare against attr vs input for consistency
9ccd64c
@eyoung55
make this general for offsets in 2 or 3 dims, previously hardcoded to 3
12ab831
@eyoung55
change path to full path from root
d65f141
@eyoung55
add thermal_analysis true to test file .yaml
e979a62
@eyoung55
don't test on 2d cyld, use sim_params instead, make input file a dict…
0adcb30 
…ionary to store lchar too
@eyoung55
change truth values for temperature solve, remove lift/drag from flag…
81b46f6 
…, needs new truth after mesh change
@eyoung55
Merge branch 'sync' into feature/sync_add_temperature
58e08b7
@eyoung55
remove comparisons to True
acfe5f2
@eyoung55
don't pass single t/f flags, pass params, store those values in class…
d416b98 
…es, don't compare against True
@eyoung55
Merge branch 'feature/sync_add_temperature' of https://github.com/bro…
733ba7b 
…okeslawski/PVade into HEAD
@arswalid
Merge pull request #73 from brookeslawski/feature/sync_add_temperature
6512a0b 
Adding heat transfer solve and velocity profile inputs
@eyoung55 eyoung55 marked this pull request as ready for review February 27, 2025 18:21
@eyoung55 eyoung55 self-requested a review February 27, 2025 18:32
eyoung55
eyoung55 approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@eyoung55 eyoung55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@arswalid arswalid merged commit 9758164 into dev Feb 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyoung55 eyoung55 eyoung55 approved these changes

Assignees

@eyoung55 eyoung55

Labels
None yet
Projects
None yet
Milestone
FY25 release
Development

Successfully merging this pull request may close these issues.
5 participants
@arswalid @eyoung55 @brookeslawski @xinhe2205 @melilly